fix Feature: inheritance checks for typed dictionaries #1346
+244
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running test.py should generate some changes, could you please include them in the commit? |
yangdanny97
reviewed
Oct 22, 2025
yangdanny97
reviewed
Oct 22, 2025
yangdanny97
reviewed
Oct 22, 2025
| "typeddicts_readonly_consistency.py": [], | ||
| "typeddicts_readonly_inheritance.py": [ | ||
| "Line 98: Expected 1 errors", | ||
| "Line 106: Expected 1 errors", |
There was a problem hiding this comment.
also, I don't think this fully fixes #52, we also have to apply these rules in multiple inheritance.
The code pointer for that is
pyrefly/pyrefly/lib/alt/class/class_field.rs
Line 2007 in 41db847
yangdanny97
requested changes
Oct 22, 2025
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D85366496. |
stroxler
requested changes
Oct 24, 2025
stroxler
approved these changes
Oct 25, 2025
yangdanny97
approved these changes
Oct 27, 2025
fangyi-zhou
reviewed
Oct 30, 2025
| | Type::Overload(_) | ||
| ) | ||
| }) { | ||
| // TODO(fangyizhou): Handle bound methods and functions properly. |
There was a problem hiding this comment.
Don't think this should be removed --- I still plan to come back to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #52